KAFKA-10892: Shared Readonly State Stores#12188
Closed
calmera wants to merge 2 commits into
Closed
Conversation
Had to migrate the MockProcessor supporting test classes to the "new" PAPI.
mjsax
reviewed
Jul 7, 2022
mjsax
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. And sorry for the long wait on a review.
As the store should be read-only, we should extend ProcessorContext#getStateStore to return a read only store if any other Processor get a handle on the store. We do a similar thing for global stores to protect them. I guess, the tricky thing will be to know if a store is read-only -- maybe we need to track some metadata about it.
Can you also rebase the PR to resolve the conflicts. Thx.
Contributor
Author
|
Split this PR into two new ones:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements KIP-813: support for shareable state stores.
Tests were created to validate the structure of the resulting topology.
Certain parts (MockProcessor eg.) have been migrated to the newer PAPI as well. Tests have been ran against the whole project to be sure this migration doesn't cause any side-effects.
The contribution is my original work and I license the work to the project under the project's open source license