Skip to content

KAFKA-12879: Addendum to reduce flakiness of tests#11871

Merged
rhauch merged 1 commit into
apache:trunkfrom
philipnee:kafka-12879-addendum-fix-flaky-tests
Mar 9, 2022
Merged

KAFKA-12879: Addendum to reduce flakiness of tests#11871
rhauch merged 1 commit into
apache:trunkfrom
philipnee:kafka-12879-addendum-fix-flaky-tests

Conversation

@philipnee

@philipnee philipnee commented Mar 9, 2022

Copy link
Copy Markdown
Contributor

This is an addendum to the KAFKA-12879 (#11797) to fix some tests that are somewhat flaky when a build machine is heavily loaded (when the timeouts are too small).

  • Add an if check to void sleep(0)
  • Increase timeout in the tests

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@philipnee

Copy link
Copy Markdown
Contributor Author

Note: See the commit 28393be

@rhauch rhauch changed the title Addendum to KAFKA 12879 to fix flaky tests KAFKA 12879: Addendum to reduce flakiness of tests Mar 9, 2022

@rhauch rhauch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending a green build. Thanks!

@rhauch rhauch changed the title KAFKA 12879: Addendum to reduce flakiness of tests KAFKA-12879: Addendum to reduce flakiness of tests Mar 9, 2022
@rhauch rhauch merged commit ddcee81 into apache:trunk Mar 9, 2022
@rhauch rhauch mentioned this pull request Mar 9, 2022
3 tasks
rhauch pushed a commit that referenced this pull request Mar 9, 2022
This is an addendum to the KAFKA-12879 (#11797) to fix some tests that are somewhat flaky when a build machine is heavily loaded (when the timeouts are too small).

- Add an if check to void sleep(0)
- Increase timeout in the tests
rhauch pushed a commit that referenced this pull request Mar 9, 2022
This is an addendum to the KAFKA-12879 (#11797) to fix some tests that are somewhat flaky when a build machine is heavily loaded (when the timeouts are too small).

- Add an if check to void sleep(0)
- Increase timeout in the tests
rhauch pushed a commit that referenced this pull request Mar 9, 2022
This is an addendum to the KAFKA-12879 (#11797) to fix some tests that are somewhat flaky when a build machine is heavily loaded (when the timeouts are too small).

- Add an if check to void sleep(0)
- Increase timeout in the tests
rhauch pushed a commit that referenced this pull request Mar 10, 2022
This is an addendum to the KAFKA-12879 (#11797) to fix some tests that are somewhat flaky when a build machine is heavily loaded (when the timeouts are too small).

- Add an if check to void sleep(0)
- Increase timeout in the tests
rhauch pushed a commit that referenced this pull request Mar 10, 2022
This is an addendum to the KAFKA-12879 (#11797) to fix some tests that are somewhat flaky when a build machine is heavily loaded (when the timeouts are too small).

- Add an if check to void sleep(0)
- Increase timeout in the tests
jeffkbkim pushed a commit to confluentinc/kafka that referenced this pull request May 12, 2022
This is an addendum to the KAFKA-12879 (apache#11797) to fix some tests that are somewhat flaky when a build machine is heavily loaded (when the timeouts are too small).

- Add an if check to void sleep(0)
- Increase timeout in the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants