KAFKA-12933: Flaky test ReassignPartitionsIntegrationTest.testReassignmentWithAlterIsrDisabled#11244
Conversation
|
@showuon can you take a look? thanks. |
|
I'll check it. Thank you for the PR. |
| val verifyAssignmentResult = runVerifyAssignment(cluster.adminClient, assignment, false) | ||
| assertTrue(verifyAssignmentResult.partsOngoing) | ||
| assertFalse(verifyAssignmentResult.movesOngoing) |
There was a problem hiding this comment.
I checked and confirmed that this change makes sense, because there might not have on-going reassignment at this moment if the reassignment completed before we verify it.
However, in this case, I don't think we verify the moveOngoing makes sense here, either, since it might passed just because the reassignment completed before the verification. I think we can directly remove all these 3 lines and directly wait for the reassignment completion. What do you think?
There was a problem hiding this comment.
verifying moveOngoing here is fine because we don't perform intra-broker replica assignments(alter log dirs) in these tests, so movesOngoing should always be false.
|
Some builds exited before completion, one completed successfully. Since this PR only removed a test assertion, we know they're unrelated. Merging to trunk and cherry-picking to 3.0. |
…nmentWithAlterIsrDisabled (#11244) Removes assertion added in #10471. It's unsafe to assert that there are partition movements ongoing for some of the tests in the suite because partitions in some of the tests have 0 data, which may complete reassignment before `verify` can run. Tests pass locally. Reviewers: Luke Chen <showuon@gmail.com>, Ismael Juma <ismael@juma.me.uk>
…nmentWithAlterIsrDisabled (apache#11244) Removes assertion added in apache#10471. It's unsafe to assert that there are partition movements ongoing for some of the tests in the suite because partitions in some of the tests have 0 data, which may complete reassignment before `verify` can run. Tests pass locally. Reviewers: Luke Chen <showuon@gmail.com>, Ismael Juma <ismael@juma.me.uk>
What
Removes assertion added in #10471
It's unsafe to assert that there are partition movements ongoing for some of the tests in the suite because partitions in some of the tests have 0 data, which may complete reassignment before
verifycan run.Testing
Tests pass locally.
Committer Checklist (excluded from commit message)