KAFKA-2340; improve KafkaConsumer Fetcher test coverage#112
Closed
hachikuji wants to merge 1 commit into
Closed
Conversation
|
kafka-trunk-git-pr #86 FAILURE |
|
kafka-trunk-git-pr #90 SUCCESS |
Contributor
There was a problem hiding this comment.
This comment is not very intuitive to understand: how about: ".. set an expectation on the request that this response is going to be returned for..."
Contributor
Author
There was a problem hiding this comment.
Yeah, that might be better. Do you think the name RequestPredicate makes the intended usage clear? I was also thinking of calling it RequestMatcher or RequestAssertion.
Contributor
Author
|
@guozhangwang Tried to make RequestMatcher comment clearer. Let me know if it helps. |
|
kafka-trunk-git-pr #99 SUCCESS |
Contributor
|
Thanks for the patch. LGTM. |
dpoldrugo
pushed a commit
to dpoldrugo/kafka
that referenced
this pull request
Nov 14, 2016
KAFKA-4361: Streams does not respect user configs for "default" params
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
xiowu0
pushed a commit
to xiowu0/kafka
that referenced
this pull request
Apr 13, 2021
…ON error (apache#118) [LI-HOTFIX] Add broker info log when getting error during fetch metadata call (apache#118) TICKET = KAFKA-12300 LI_DESCRIPTION = LIKAFKA-33540 This will backport pr (apache#112) to log which broker returned metadata request and help us debug a Venice issue that potentially stemmed from metadata propagation delay EXIT_CRITERIA = Upstream pr created and merged, we can close this after pulling in upstream pr
xiowu0
pushed a commit
to xiowu0/kafka
that referenced
this pull request
Apr 13, 2021
…ON error (apache#112) [LI-HOTFIX] Add broker info log when getting error during fetch metadata call (apache#112) TICKET = KAFKA-12300 LI_DESCRIPTION = LIKAFKA-33540 This will log which broker returned metadata request and help us debug a Venice issue that potentially stemmed from metadata propagation delay EXIT_CRITERIA = Upstream pr created and merged, we can close this after pulling in upstream pr
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jan 16, 2022
…ON error (apache#112) TICKET = KAFKA-12300 LI_DESCRIPTION = LIKAFKA-33540 This will log which broker returned metadata request and help us debug a Venice issue that potentially stemmed from metadata propagation delay EXIT_CRITERIA = Upstream pr created and merged, we can close this after pulling in upstream pr
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 4, 2022
…ON error (apache#112) TICKET = KAFKA-12300 LI_DESCRIPTION = LIKAFKA-33540 This will log which broker returned metadata request and help us debug a Venice issue that potentially stemmed from metadata propagation delay EXIT_CRITERIA = Upstream pr created and merged, we can close this after pulling in upstream pr
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
…ON error (apache#112) TICKET = KAFKA-12300 LI_DESCRIPTION = LIKAFKA-33540 This will log which broker returned metadata request and help us debug a Venice issue that potentially stemmed from metadata propagation delay EXIT_CRITERIA = Upstream pr created and merged, we can close this after pulling in upstream pr
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
…ON error (apache#112) TICKET = KAFKA-12300 LI_DESCRIPTION = LIKAFKA-33540 This will log which broker returned metadata request and help us debug a Venice issue that potentially stemmed from metadata propagation delay EXIT_CRITERIA = Upstream pr created and merged, we can close this after pulling in upstream pr
k0b3rIT
added a commit
to k0b3rIT/kafka
that referenced
this pull request
Mar 24, 2025
… (apache#112) Change-Id: Ibcd9c146f001c8359bb0f2c25683b9fabbf47df0 Co-authored-by: Bertalan Kondrat <kb.pcre@gmail.com>
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
…rty-based tests on committed data (apache#112) Signed-off-by: Greg Harris <greg.harris@aiven.io>
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Mar 27, 2026
avoid unnecessary batch traversing for mirror pid reset batch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.