Skip to content

optimize: upgrade axios to 1.12.2#7699

Merged
slievrly merged 3 commits into
apache:2.xfrom
jihun4452:fix/axios-upgrade
Oct 16, 2025
Merged

optimize: upgrade axios to 1.12.2#7699
slievrly merged 3 commits into
apache:2.xfrom
jihun4452:fix/axios-upgrade

Conversation

@jihun4452

Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR did

This PR upgrades axios in the console frontend to version ^1.12.2 (and updates the lockfile to 1.12.2) to address the security vulnerability CVE-2025-58754.

Ⅱ. Does this pull request fix one issue?

fixes #7659

Ⅲ. Why don't you add test cases (unit test/integration test)?

No behavioral change was introduced—only a dependency version bump—so no new tests are required.

Ⅳ. Describe how to verify it

  1. Run npm ls axios → should output axios@1.12.2
  2. Confirm package.json contains "axios": "^1.12.2"
  3. Confirm package-lock.json shows axios 1.12.2
  4. (optional) Run npm run build to ensure the console frontend builds successfully.

Ⅴ. Special notes for reviews

  • Scope strictly limited to axios dependency update.
  • No source-code or behavioral changes.
  • Maintains backward compatibility and aligns with Apache Seata’s security policy.

@codecov

codecov Bot commented Oct 15, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.47%. Comparing base (8763897) to head (efeab7b).
⚠️ Report is 2 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7699      +/-   ##
============================================
- Coverage     61.52%   61.47%   -0.06%     
  Complexity      680      680              
============================================
  Files          1314     1314              
  Lines         49890    49890              
  Branches       5878     5878              
============================================
- Hits          30696    30670      -26     
- Misses        16404    16430      +26     
  Partials       2790     2790              

see 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@YongGoose YongGoose left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maple525866

Copy link
Copy Markdown
Contributor

Please add changes to 2.x md @jihun4452

@jihun4452

Copy link
Copy Markdown
Contributor Author

Thank you! I’ve added the changes to 2.x.md.

@slievrly slievrly changed the title fix: upgrade axios to 1.12.2 #7659 optimize: upgrade axios to 1.12.2 Oct 16, 2025
@slievrly slievrly added this to the 2.6.0 milestone Oct 16, 2025
@slievrly slievrly mentioned this pull request Oct 16, 2025
2 tasks
Comment thread changes/en-us/2.x.md Outdated

- [[#7632](https://github.com/apache/incubator-seata/pull/7632)] upgrade sha.js to version 2.4.12
- [[#7633](https://github.com/apache/incubator-seata/pull/7633)] Upgrade cipher-base to version 1.0.6
- [[#7659](https://github.com/apache/incubator-seata/pull/7659)] Upgrade axios to version 1.12.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The serial number should be 7699 instead of 7659, which is the serial number of pr

Comment thread changes/zh-cn/2.x.md Outdated
- [[#7632](https://github.com/apache/incubator-seata/pull/7632)] 升级sha.js为2.4.12
- [[#7633](https://github.com/apache/incubator-seata/pull/7633)] 升级cipher-base为1.0.6

- [[#7659](https://github.com/apache/incubator-seata/pull/7659)] 升级axios到1.12.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! The wrong PR number has been fixed.

@maple525866

Copy link
Copy Markdown
Contributor

LGTM

@slievrly slievrly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 6a6868d into apache:2.x Oct 16, 2025
11 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade axios to version 1.12.0 or later

4 participants