test: deflake ConsulConfigurationTest#testInitSeataConfig (#7584)#7584
Conversation
… short await/retry to absorb CI timing delay (fixes apache#7583) Signed-off-by: 박지훈 <jihun6548@naver.com>
|
CI-only deflake; no production code changes. |
funky-eyes
left a comment
There was a problem hiding this comment.
Please register your PR in those two files :
https://github.com/apache/incubator-seata/blob/2.x/changes/zh-cn/2.x.md
https://github.com/apache/incubator-seata/blob/2.x/changes/en-us/2.x.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7584 +/- ##
=========================================
Coverage 61.36% 61.37%
Complexity 658 658
=========================================
Files 1310 1310
Lines 49568 49568
Branches 5834 5834
=========================================
+ Hits 30416 30420 +4
+ Misses 16436 16435 -1
+ Partials 2716 2713 -3 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ig with short await/retry to absorb CI timing delay
|
I will open and close this PR several times in order to rerun the CI, so that I can determine whether the issue is likely to be fixed. |
|
I’d like the title to be a bit more concise, this one is a little too long. |
c4a58f4 to
e35396a
Compare
|
I've updated the PR title to make it more concise as suggested. Please review. |
|
Sorry for the interruption earlier — it seems the CI run was interrupted. |
This failure is indeed unrelated to this PR, but I’m not sure why the mock server was shut down while running MockTest#doTestRollback. |
|
Thanks for the review. The original flake in ConsulConfigurationTest#testInitSeataConfig should be addressed by this PR. |
funky-eyes
left a comment
There was a problem hiding this comment.
LGTM
If you're using the DingTalk app, please send your DingTalk account to my email at jianbin@apache.org, and I will invite you to join the Seata developer group
|
If you're using the DingTalk app, please send your DingTalk account to my email at |
|
Thanks for the review and merge! |
You can subscribe to Seata’s dev mailing list by following this guide: https://seata.apache.org/docs/developers/contributor-guide/new-contributor-guide_dev/. You’re also welcome to follow the Seata community’s GitHub repository. Of course, if you’re interested in registering a DingTalk account, that would be even better. |
|
Thanks for sharing the link. I’ll check the mailing list guide and join there. I’ll also follow the Seata GitHub repo to keep up with updates. If possible in the future, I’ll register a DingTalk account as well. |
(N/A for this PR: test-only, no user-facing change)
Ⅰ. Describe what this PR did
Deflake
ConsulConfigurationTest.testInitSeataConfigby adding a short await/retry loop (up to ~3s with 100ms backoff).This absorbs occasional CI timing/propagation delays when reading the mocked Consul KV so the assertion remains stable.
No production code changes — test-only.
Ⅱ. Does this pull request fix one issue?
Fixes #7583.
Ⅲ. Why don't you add test cases (unit test/integration test)?
This PR modifies the failing test itself. The flakiness comes from timing, not functionality, so adding new tests would not add coverage.
Ⅳ. Describe how to verify it
Run the module tests repeatedly and confirm they pass:
Ⅴ. Special notes for reviews