Skip to content

Fix features BackoffManager Unit Tests in Resource-Constrained Environments#494

Merged
arturobernalg merged 1 commit intoapache:5.4.xfrom
arturobernalg:backoffManagerFailuresTest
Oct 20, 2023
Merged

Fix features BackoffManager Unit Tests in Resource-Constrained Environments#494
arturobernalg merged 1 commit intoapache:5.4.xfrom
arturobernalg:backoffManagerFailuresTest

Conversation

@arturobernalg
Copy link
Copy Markdown
Member

This enhancement ensures that the tests for 'BackoffManager' run successfully even in resource-constrained environments, making them more resilient and reliable .

…nments.

This commit improves the reliability of BackoffManager unit tests by replacing the use of Thread.sleep() with a more robust approach that manipulates lastRouteProbes to simulate the cooldown period. This enhancement ensures that the tests run successfully even in resource-constrained environments, making them more resilient and reliable.
@arturobernalg arturobernalg requested a review from ok2c October 18, 2023 20:54
@arturobernalg
Copy link
Copy Markdown
Member Author

@ok2c could you please review this? It aims to resolve the issues related to the BackoffManager tests.

Copy link
Copy Markdown
Member

@ok2c ok2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arturobernalg Test cases pass for me. I did not look closely at the test source code but I am glad that busy waiting loops are gone now.

@arturobernalg arturobernalg merged commit 5c61b0a into apache:5.4.x Oct 20, 2023
ok2c pushed a commit that referenced this pull request Dec 6, 2023
…nments. (#494)

This commit improves the reliability of BackoffManager unit tests by replacing the use of Thread.sleep() with a more robust approach that manipulates lastRouteProbes to simulate the cooldown period. This enhancement ensures that the tests run successfully even in resource-constrained environments, making them more resilient and reliable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants