NNStorage does not synchronize iteration on a synchronized list#64
NNStorage does not synchronize iteration on a synchronized list#64emopers wants to merge 1 commit intoapache:trunkfrom
Conversation
|
Thanks for your contribution emopers. Could you please follow these steps? https://wiki.apache.org/hadoop/HowToContribute |
Add getCommandsTableItem() in DBAdapter
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…eason Retry-reason in x-ms-client-request-id
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
In line 839 of NNStroage.java#reportErrorsOnDirectories, the synchronized list,
sdsis iterated in an unsynchronized manner, but according to Oracle Java 7 API specification,
this is not thread-safe and can lead to non-deterministic behavior.
This pull request adds a fix by synchronizing the iteration on
sds. The synchronized list is passed to methodreportErrorsOnDirectoriesfrom here