[GLUTEN-7028][CH][Part-8] Support one pipeline write for partition mergetree#7924
Merged
baibaichen merged 4 commits intoapache:mainfrom Nov 13, 2024
Merged
Conversation
[Refactor] SparkPartitionedBaseSink and WriteStatsBase
|
Run Gluten Clickhouse CI on x86 |
11 tasks
zzcclp
approved these changes
Nov 13, 2024
philo-he
pushed a commit
to philo-he/gluten
that referenced
this pull request
Nov 13, 2024
…rgetree (apache#7924) * [Refactor] simple refactor * [Refactor] Remove setStats * [Refactor] SparkPartitionedBaseSink and WriteStatsBase * [Refactor] Add explicit SparkMergeTreeWriteSettings(const DB::ContextPtr & context); * [New] Support writing partition mergetree in one pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Fixes: #7028)
The following digram shows the current class hierarchy，
SparkPartitionedBaseSinkinherits from ch'sDB::PartitionedSinkThe partition MergeTree in pipeline write looks like this, it squashes block before partitiion for whole input:
It differs from spark 3.3 which squashes block after partitiion for each partition, since parition is triggerd by JVM.
The new implemwentation is same as clickhouse.
How was this patch tested?
Using existed UTs