[GLUTEN-7028][CH][Part-3] Refactor: Move mergetree related codes to backends-clickhouse#7234
Merged
baibaichen merged 13 commits intoapache:mainfrom Sep 26, 2024
Merged
Conversation
11 tasks
|
Run Gluten Clickhouse CI |
a879269 to
46166be
Compare
|
Run Gluten Clickhouse CI |
46166be to
04682c9
Compare
|
Run Gluten Clickhouse CI |
04682c9 to
3421f0d
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
79727d7 to
8ce0620
Compare
|
Run Gluten Clickhouse CI |
8ce0620 to
eac0c7b
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
4c0e635 to
3961fdc
Compare
|
Run Gluten Clickhouse CI |
3961fdc to
36862c0
Compare
|
Run Gluten Clickhouse CI |
4 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
| * limitations under the License. | ||
| */ | ||
| package org.apache.gluten.init; | ||
| package org.apache.gluten.jni; |
Member
There was a problem hiding this comment.
If we move it to gluten-core, could we do some minor refactors on this class at the same time? My suggestion would be:
org.apache.gluten.jni.JniUtils->org.apache.gluten.utils.ConfigUtilJniUtils.toNativeConf->ConfigUtil.serializeorConfigUtil.serializeMap
Thanks.
498934f to
1821993
Compare
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
771ec15 to
8b9f159
Compare
|
Run Gluten Clickhouse CI |
8b9f159 to
6f875ea
Compare
|
Run Gluten Clickhouse CI |
6f875ea to
c50e45a
Compare
|
Run Gluten Clickhouse CI |
c50e45a to
ef1fa30
Compare
|
Run Gluten Clickhouse CI |
2. Using ConfigMap to pass configuration between java and c++ 3. using config.proto 4. Move mergetree related codes to backends-clickhouse
JniUtils.toNativeConf -> ConfigUtil.serialize
ef1fa30 to
d9678a5
Compare
|
Run Gluten Clickhouse CI |
zhztheplayer
approved these changes
Sep 26, 2024
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
…ackends-clickhouse (apache#7234) This is second refacor PR for moving mergetree related codes to backends-clickhouse: 1. Move JniUtils from gluten-arrow to gluten-core and using config.proto, so we can use ConfigMap to pass configuration between java and c++. 2. Move ExtensionTableXXX from gluten-substrait to backends-clickhouse 3. Move `genWriteParameters` to `TransformerApi`, so we can pass mergetree related parameters. (Fixes: \apache#7028)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is second refacor PR for moving mergetree related codes to backends-clickhouse:
genWriteParameterstoTransformerApi, so we can pass mergetree related parameters.(Fixes: #7028)
How was this patch tested?
Using Existed UTs