Skip to content

[GLUTEN-6813][CH] Support soundex function#7093

Merged
taiyang-li merged 4 commits intoapache:mainfrom
bigo-sg:gluten_6813
Sep 5, 2024
Merged

[GLUTEN-6813][CH] Support soundex function#7093
taiyang-li merged 4 commits intoapache:mainfrom
bigo-sg:gluten_6813

Conversation

@taiyang-li
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #6813)

How was this patch tested?

Original spark test "soundex function" in GlutenStringFunctionsSuite

@github-actions github-actions bot added CORE works for Gluten Core CLICKHOUSE labels Sep 3, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 3, 2024

#6813

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 3, 2024

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 3, 2024

Run Gluten Clickhouse CI

exmy
exmy previously approved these changes Sep 4, 2024
@baibaichen
Copy link
Copy Markdown
Contributor

@exmy where is the ut to test this funtion?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 4, 2024

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 4, 2024

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 4, 2024

Run Gluten Clickhouse CI

Copy link
Copy Markdown
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taiyang-li taiyang-li merged commit 138931e into apache:main Sep 5, 2024
@taiyang-li
Copy link
Copy Markdown
Contributor Author

image

dcoliversun pushed a commit to dcoliversun/gluten that referenced this pull request Sep 11, 2024
* support soundex function

* add uts

* fix style

* fix failed uts
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
* support soundex function

* add uts

* fix style

* fix failed uts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLICKHOUSE CORE works for Gluten Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CH] support function SoundEx

4 participants