[CORE] Following #6745, append some minor code cleanups#6788
Merged
zhztheplayer merged 1 commit intoapache:mainfrom Aug 13, 2024
Merged
[CORE] Following #6745, append some minor code cleanups#6788zhztheplayer merged 1 commit intoapache:mainfrom
zhztheplayer merged 1 commit intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
JkSelf
approved these changes
Aug 13, 2024
Contributor
JkSelf
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your fix.
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch mainly moves the
KnownChildrenConventions/KnownRowTypeup toColumnarWriteFilesExecas its direct dependency to keep trait classExecuteWriteCompatibleminimal.And some minors.
Link #6745