[GLUTEN-11550][UT] Enable GlutenXmlExpressionsSuite for spark4x and exclude 'from_xml- invalid data'#11580
Merged
baibaichen merged 1 commit intoapache:mainfrom Feb 28, 2026
Conversation
|
Run Gluten Clickhouse CI on x86 |
5f428d5 to
b6a2397
Compare
|
Run Gluten Clickhouse CI on x86 |
b6a2397 to
e88091c
Compare
|
Run Gluten Clickhouse CI on x86 |
e88091c to
4fb4dec
Compare
|
Run Gluten Clickhouse CI on x86 |
4fb4dec to
e8e4904
Compare
…ml- invalid data' - Enable GlutenXmlExpressionsSuite in VeloxTestSettings (was TODO disabled) - Fix mixin: GlutenTestsCommonTrait → GlutenTestsTrait. The prior PR (apache#11512) added GlutenXmlExpressionsSuite with GlutenTestsCommonTrait, which does not enable Gluten execution for the test suite. - Exclude 'from_xml- invalid data': Gluten overrides checkEvaluation to execute expressions via DataFrame, which throws SparkException directly instead of wrapping it in TestFailedException. Same pattern as 'from_json - invalid data'.
e8e4904 to
22b5cd8
Compare
zhli1142015
approved these changes
Feb 28, 2026
weiting-chen
approved these changes
Feb 28, 2026
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Mar 9, 2026
The woodstox classpath conflict that caused 10 failures was already fixed by PR apache#11580. All 31 tests pass on both spark40 and spark41. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Mar 11, 2026
The woodstox classpath conflict that caused 10 failures was already fixed by PR apache#11580. All 31 tests pass on both spark40 and spark41. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
zhztheplayer
pushed a commit
to zhztheplayer/gluten
that referenced
this pull request
Mar 15, 2026
….1 (apache#11725) The woodstox classpath conflict that caused 10 failures was already fixed by PR apache#11580. All 31 tests pass on both spark40 and spark41. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes #11550 (partial)
GlutenXmlExpressionsSuitein VeloxTestSettings for both spark40 and spark41 (was TODO disabled for spark41)GlutenTestsCommonTrait→GlutenTestsTrait. The prior PR ([UT] Add missing Gluten test suites for Spark 4.0 and 4.1 #11512) addedGlutenXmlExpressionsSuitewithGlutenTestsCommonTrait, which does not enable Gluten execution for the test suite.from_xml- invalid data: Gluten overridescheckEvaluationto execute expressions via DataFrame (df.select().collect()), which throwsSparkExceptiondirectly instead of wrapping it inTestFailedException. Same pattern asfrom_json - invalid data.hadoop-commontransitive dependency fromhive-llap-commonin bothgluten-ut/pom.xmland spark-specific pom files. Hadoop ships a shaded woodstox (org.apache.hadoop.shaded.com.ctc.wstx.*) whose property names are incompatible with the non-shaded woodstox used by Spark XML, causingIllegalArgumentException: Unrecognized propertyinto_xmltests.How was this patch tested?
Ran
GlutenXmlExpressionsSuiteon both spark40 and spark41:from_xml- invalid data) ✅from_xml- invalid data) ✅Compiled successfully with both
spark-4.0andspark-4.1profiles.Was this patch authored or co-authored using generative AI tooling?
Generated-by: GitHub Copilot CLI