[GLUTEN-10834][CORE] Prefer hyphens over underscores in shell script names#10836
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
783e1a1 to
0489d69
Compare
|
Run Gluten Clickhouse CI on x86 |
- over _ in script names where possible
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Zouxxyy
commented
Oct 3, 2025
Zouxxyy
left a comment
Contributor
Author
There was a problem hiding this comment.
CC @zhztheplayer @philo-he , thanks
6f5d8ed to
202f9bd
Compare
|
Run Gluten Clickhouse CI on x86 |
Member
|
Thank you @Zouxxyy for taking this on! |
- over _ in script names where possible
philo-he
reviewed
Oct 3, 2025
philo-he
left a comment
Member
There was a problem hiding this comment.
I also felt that we should adopt a consistent naming convention.
Member
|
Thank you for the insights @philo-he. We are on the same page. |
Member
202f9bd to
d80af38
Compare
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
approved these changes
Oct 8, 2025
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
2f0c063 to
7c641d5
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
I believe the failed ci was introduces after facebookincubator/velox#14849 |
zhztheplayer
approved these changes
Oct 10, 2025
Member
|
@Zouxxyy Would you want to rebase the PR? As I saw we have successful build in the past few days. |
Contributor
Author
|
@zhztheplayer Will rebase once involved facebookincubator/velox#15132, the failed CI is the Velox Bachkend Weekly Job (should still fail at this point) |
Contributor
Author
Member
|
Sounds good to me. Thanks. |
7c641d5 to
f509282
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
@zhztheplayer I rebased. the UT that failed previously has passed, and the current failure should be irrelevant |
Member
|
Thanks! |
zhztheplayer
approved these changes
Oct 16, 2025
meta-codesync Bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Oct 20, 2025
…led (#15113) Summary: In apache/gluten#10836, we encountered a Velox compilation issue caused by the changes introduced in #14849. The error occurred because ABSOLUTE_SCRIPTDIR was modified. ``` 2025-10-09T03:42:02.6189401Z ++ realpath scripts 2025-10-09T03:42:02.6207867Z + ABSOLUTE_SCRIPTDIR=/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts 2025-10-09T03:42:02.6210432Z + VELOX_ARROW_CMAKE_PATCH=/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts/../CMake/resolve_dependency_modules/arrow/cmake-compatibility.patch 2025-10-09T03:42:02.6212114Z + cd /__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/arrow 2025-10-09T03:42:02.6213956Z + git apply /__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts/../CMake/resolve_dependency_modules/arrow/cmake-compatibility.patch 2025-10-09T03:42:02.6230732Z error: can't open patch '/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts/../CMake/resolve_dependency_modules/arrow/cmake-compatibility.patch': No such file or directory 2025-10-09T03:42:02.6235097Z + exit 1 ``` Pull Request resolved: #15113 Reviewed By: bikramSingh91 Differential Revision: D85060996 Pulled By: pedroerp fbshipit-source-id: 255eb7a82bc3d9ffb6c47e2a4c96066b4974823e
mhaseeb123
pushed a commit
to mhaseeb123/velox
that referenced
this pull request
Oct 27, 2025
…led (facebookincubator#15113) Summary: In apache/gluten#10836, we encountered a Velox compilation issue caused by the changes introduced in facebookincubator#14849. The error occurred because ABSOLUTE_SCRIPTDIR was modified. ``` 2025-10-09T03:42:02.6189401Z ++ realpath scripts 2025-10-09T03:42:02.6207867Z + ABSOLUTE_SCRIPTDIR=/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts 2025-10-09T03:42:02.6210432Z + VELOX_ARROW_CMAKE_PATCH=/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts/../CMake/resolve_dependency_modules/arrow/cmake-compatibility.patch 2025-10-09T03:42:02.6212114Z + cd /__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/arrow 2025-10-09T03:42:02.6213956Z + git apply /__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts/../CMake/resolve_dependency_modules/arrow/cmake-compatibility.patch 2025-10-09T03:42:02.6230732Z error: can't open patch '/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts/../CMake/resolve_dependency_modules/arrow/cmake-compatibility.patch': No such file or directory 2025-10-09T03:42:02.6235097Z + exit 1 ``` Pull Request resolved: facebookincubator#15113 Reviewed By: bikramSingh91 Differential Revision: D85060996 Pulled By: pedroerp fbshipit-source-id: 255eb7a82bc3d9ffb6c47e2a4c96066b4974823e
Alan-S-Andrade
pushed a commit
to Alan-S-Andrade/velox
that referenced
this pull request
Jun 2, 2026
…led (facebookincubator#15113) Summary: In apache/gluten#10836, we encountered a Velox compilation issue caused by the changes introduced in facebookincubator#14849. The error occurred because ABSOLUTE_SCRIPTDIR was modified. ``` 2025-10-09T03:42:02.6189401Z ++ realpath scripts 2025-10-09T03:42:02.6207867Z + ABSOLUTE_SCRIPTDIR=/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts 2025-10-09T03:42:02.6210432Z + VELOX_ARROW_CMAKE_PATCH=/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts/../CMake/resolve_dependency_modules/arrow/cmake-compatibility.patch 2025-10-09T03:42:02.6212114Z + cd /__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/arrow 2025-10-09T03:42:02.6213956Z + git apply /__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts/../CMake/resolve_dependency_modules/arrow/cmake-compatibility.patch 2025-10-09T03:42:02.6230732Z error: can't open patch '/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/abseil-cpp/scripts/../CMake/resolve_dependency_modules/arrow/cmake-compatibility.patch': No such file or directory 2025-10-09T03:42:02.6235097Z + exit 1 ``` Pull Request resolved: facebookincubator#15113 Reviewed By: bikramSingh91 Differential Revision: D85060996 Pulled By: pedroerp fbshipit-source-id: 255eb7a82bc3d9ffb6c47e2a4c96066b4974823e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
use - as much as possible, unless _ is really needed for a naming in scripts, I checked the scrips in such dirs
How was this patch tested?