feat(rust): support dyn any trait object serialization for box/arc/rc #2704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urlyy
approved these changes
Oct 6, 2025
chaokunyang
commented
Oct 6, 2025
| } else { | ||
| type_resolver | ||
| .get_harness(fory_type_id) | ||
| .expect("ID harness not found") |
Collaborator
Author
There was a problem hiding this comment.
TODO: return Error instead of panic
2 tasks
This was referenced Oct 6, 2025
chaokunyang
added a commit
that referenced
this pull request
Oct 6, 2025
## Why? <!-- Describe the purpose of this PR. --> ## What does this PR do? This PR supports shared ref for arc/rc<dny T> by forward serialization/deserialization to `arc/rc<dny T>` using `upcast/downcast` ## Related issues Closes #2705 #2691 #2704 ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fory/issues/new/choose) describing the need to do so and update the document if necessary. Delete section if not applicable. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. Delete section if not applicable. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
What does this PR do?
suport dyn any trait object serialization for box/arc/rc:
ForyDefaulttrait to work around orphan rule, so we can impldefaultforRc<dny Any>Foryderive toForyObjectderiveBox/Rc/Arc<any>Rc/Arc<any>write_any_typeinfo/read_typeinfofor dynamic type-meta read/writeRelated issues
#2691
#1797
#1795
Does this PR introduce any user-facing change?
Benchmark