feat(java): meta string encoding algorithm in java #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@theweipeng @PragmaTwice @LiangliangSui This PR is ready for review, could you help review it? |
2 tasks
chaokunyang
added a commit
that referenced
this pull request
Apr 15, 2024
## What does this PR do? This PR renames EnumString to MetaString ## Related issues #1514 ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/incubator-fury/issues/new/choose) describing the need to do so and update the document if necessary. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. -->
java/fury-core/src/main/java/org/apache/fury/meta/MetaStringEncoder.java
Outdated
Show resolved
Hide resolved
java/fury-core/src/main/java/org/apache/fury/meta/MetaStringEncoder.java
Outdated
Show resolved
Hide resolved
java/fury-core/src/main/java/org/apache/fury/meta/MetaStringEncoder.java
Outdated
Show resolved
Hide resolved
c27ef1c to
ba43740
Compare
java/fury-core/src/main/java/org/apache/fury/meta/MetaStringEncoder.java
Outdated
Show resolved
Hide resolved
This was referenced Apr 19, 2024
chaokunyang
added a commit
that referenced
this pull request
Apr 27, 2024
## What does this PR do? This PR implements meta string encoding described in [xlang serialization spec](https://fury.apache.org/docs/specification/fury_xlang_serialization_spec#meta-string) ## Related issues - #1240 - #1413 - #1514 ## Does this PR introduce any user-facing change? - [No] Does this PR introduce any public API change? - [No] Does this PR introduce any binary protocol compatibility change? --------- Co-authored-by: Shawn Yang <chaokunyang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements meta string encoding described in fury java serialization spec and xlang serialization spec
We have
3/8space saveing for most string:The integration with ClassResolver is left in another PR.
Related issues
#1240
#1413
Does this PR introduce any user-facing change?
Benchmark