[lake/paimon] Fix partition expiration never triggered in Paimon lake table managed by Tiering Service#2862
Merged
Conversation
… table managed by Tiering Service
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Paimon lake-table partition expiration not being triggered when tables are managed by the Fluss Tiering Service, addressing the lifecycle mismatch where a new Paimon TableCommitImpl is created every tiering round.
Changes:
- Enable Paimon
end-input.check-partition-expireinPaimonLakeCommitterwhen snapshot expiration is enabled (i.e., non-write-only commits). - Add a parameterized unit test that simulates multiple tiering rounds and validates partition expiration behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/PaimonLakeCommitter.java | Enables Paimon’s end-input partition-expiration trigger during non-write-only tiering commits. |
| fluss-lake/fluss-lake-paimon/src/test/java/org/apache/fluss/lake/paimon/tiering/PaimonTieringTest.java | Adds coverage to ensure partition expiration occurs across repeated tiering rounds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+439
to
+446
| // Use a fixed ancient date so the partition is always considered expired. | ||
| // "20200101" with expiration-time=1d is always past-due – no wall-clock dependency. | ||
| String expiredPartition = "20200101"; | ||
|
|
||
| Map<String, String> tableOptions = new HashMap<>(); | ||
| tableOptions.put(CoreOptions.PARTITION_EXPIRATION_TIME.key(), "1 d"); | ||
| tableOptions.put(CoreOptions.PARTITION_EXPIRATION_CHECK_INTERVAL.key(), "10 min"); | ||
| tableOptions.put(CoreOptions.PARTITION_TIMESTAMP_FORMATTER.key(), "yyyyMMdd"); |
hemanthsavasere
pushed a commit
to hemanthsavasere/fluss
that referenced
this pull request
Mar 14, 2026
… table managed by Tiering Service (apache#2862)
wxplovecc
pushed a commit
to tongcheng-elong/fluss
that referenced
this pull request
Apr 17, 2026
… table managed by Tiering Service (apache#2862)
wxplovecc
pushed a commit
to tongcheng-elong/fluss
that referenced
this pull request
Apr 20, 2026
… table managed by Tiering Service (apache#2862)
Ugbot
pushed a commit
to Ugbot/fluss
that referenced
this pull request
Apr 26, 2026
… table managed by Tiering Service (apache#2862)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2861
Brief change log
Tests
API and Format
Documentation