[ISSUE #815] feature: Rust sdk #1156
Conversation
There was a problem hiding this comment.
Welcome to the Apache EventMesh (incubating) community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
WeChat Group：
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
|
@RiESAEX Nice job, I suggest you submit by servral smaller PRs, thx. |
| unique_id: unique_id.to_string(), | ||
| topic: topic.to_string(), | ||
| content: content.to_string(), | ||
| ttl, |
There was a problem hiding this comment.
If the code is not used subsequently, it may be possible to remove the commented out code.
There was a problem hiding this comment.
for create_time
https://github.com/apache/incubator-eventmesh/blob/8b2f3fd38051fa85fe0f48421eb12e4d03205b42/eventmesh-common/src/main/java/org/apache/eventmesh/common/EventMeshMessage.java#L44
there is a field in java code, but it was not used (may be used in logger?). I'm not sure if it's needed so I just commented it.
for ths prop, I just not sure what it is.
I found it only store the TTL (except test code of EventMeshMessage).
https://github.com/apache/incubator-eventmesh/blob/8b2f3fd38051fa85fe0f48421eb12e4d03205b42/eventmesh-protocol-plugin/eventmesh-protocol-grpc/src/main/proto/eventmesh-client.proto#L46-L50
In grpc producer, the message already has a TTL field and prop is sent,
https://github.com/apache/incubator-eventmesh/blob/8b2f3fd38051fa85fe0f48421eb12e4d03205b42/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/http/producer/EventMeshMessageProducer.java#L138
In http producer, I think the prop was not even send (It just pick up the ttl in it, and put it to header).
There was a problem hiding this comment.
Ok, I see, you don't seem to have added a license, maybe you need to add it.
Codecov Report
@@ Coverage Diff @@
## master #1156 +/- ##
===========================================
- Coverage 10.92% 9.88% -1.05%
+ Complexity 730 637 -93
===========================================
Files 403 382 -21
Lines 24346 23640 -706
Branches 2680 2619 -61
===========================================
- Hits 2659 2336 -323
+ Misses 21430 21081 -349
+ Partials 257 223 -34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@RiESAEX I suggest submitting by several smaller PRs. |
|
@RiESAEX please take care of the CI fail tasks. |
Resolve #815
Motivation
this PR is create to reduce potential duplicate work of rust sdk
Modifications
eventmesh-sdk-rust/
Jobs