Skip to content

Tooltip dom append to body, use to top of layer#8049

Merged
100pah merged 3 commits intoapache:masterfrom
xinpureZhu:master
Jan 9, 2020
Merged

Tooltip dom append to body, use to top of layer#8049
100pah merged 3 commits intoapache:masterfrom
xinpureZhu:master

Conversation

@xinpureZhu
Copy link
Copy Markdown
Contributor

#4627 解决 Tooltip 被其它图形遮挡的问题
1522255894822

@pissang
Copy link
Copy Markdown
Contributor

pissang commented Mar 29, 2018

谢谢!这个 PR 中好像没有处理 tooltip 组件移除或者图表 dispose 后浮层的移除

@xinpureZhu
Copy link
Copy Markdown
Contributor Author

疏乎了,已补上提交

@balthazar
Copy link
Copy Markdown

你好! Any update on this?

@joenzhu
Copy link
Copy Markdown

joenzhu commented Nov 12, 2019

can anyone merge this pr?

dktjsp
dktjsp previously approved these changes Nov 15, 2019
@pissang pissang added this to the 4.7.0 milestone Nov 18, 2019
@pissang pissang requested a review from 100pah November 18, 2019 02:54
@100pah
Copy link
Copy Markdown
Member

100pah commented Jan 9, 2020

This issue will be merged. Thanks to the great contribution of @xinpureZhu .

But a new option tooltip.appendToBody will be added to open this feature.
By default tooltip.appendToBody should be false, otherwise it is probably a big break change for some existing deep-customization usage.
And there would be more factors needed to be considered to ensure the "append to body" works correctly. Subsequent PR is under way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants