fix incorrect definition of instance variable name#7547
Merged
AlbumenJ merged 1 commit intoapache:masterfrom Apr 15, 2021
Merged
fix incorrect definition of instance variable name#7547AlbumenJ merged 1 commit intoapache:masterfrom
AlbumenJ merged 1 commit intoapache:masterfrom
Conversation
Author
|
The instance name here is not necessarily NIO_EVENT_LOOP_GROUP, the internal logic is to determine whether it is an epoll model according to the shouldEpoll() method, so as to decide whether to choose EpollEventLoopGroup or NioEventLoopGroup |
Codecov Report
@@ Coverage Diff @@
## master #7547 +/- ##
============================================
- Coverage 58.78% 58.76% -0.02%
Complexity 502 502
============================================
Files 1076 1076
Lines 43409 43409
Branches 6339 6339
============================================
- Hits 25516 25509 -7
- Misses 15054 15070 +16
+ Partials 2839 2830 -9
Continue to review full report at Codecov.
|
AlbumenJ
added a commit
to AlbumenJ/dubbo
that referenced
this pull request
May 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix incorrect definition of instance variable name
Brief changelog
Verifying this change
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.