Merged
Conversation
|
|
xpylq
pushed a commit
to xpylq/dubbo
that referenced
this pull request
Oct 24, 2017
* remotes/upstream/master: Fix all unit test case Merge pull request apache#107 from sonicwu:master Open UT on travis Merge pull request apache#749 from Just-CJ:master Fix config error of heartbeat UT in dubbo-test-examples Merge pull request apache#755 from Elin-Zhou:master Merge pull request apache#748 from mysqto:master Merge pull request apache#765 from hollyshi:patch-1 Delete dubbo1 rpc protocol copatipable logic Create Contributing.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegistryDirectory里面这段代码，完全可以先对invokers先做一遍route，因为不是所有路由策略都是方法级别的
之所以想改这个，是因为我们公司开发了一个api网关（基于dubbox的），是一个伪造的dubbo comsumer，也能用dubbo的服务发现，但是我本地类只是一个httpClient，代码上做了一些侵入性改造，执行到下面这段代码时serviceMethods这个变量是null，按照原来的逻辑只要serviceMethods为null，就不会做路由了，但是我希望至少支持service级别的路由