to fix something wrong with MergeableClusterInvoker#7360
Merged
AlbumenJ merged 2 commits intoapache:masterfrom Mar 11, 2021
Merged
to fix something wrong with MergeableClusterInvoker#7360AlbumenJ merged 2 commits intoapache:masterfrom
AlbumenJ merged 2 commits intoapache:masterfrom
Conversation
…he resultType of "resultList.iterator().next()" is AppResponse, which would throw an exception of UnsupportedOperationException
Codecov Report
@@ Coverage Diff @@
## master #7360 +/- ##
============================================
+ Coverage 58.67% 58.69% +0.02%
- Complexity 424 426 +2
============================================
Files 1044 1044
Lines 42488 42486 -2
Branches 6231 6230 -1
============================================
+ Hits 24928 24939 +11
+ Misses 14768 14753 -15
- Partials 2792 2794 +2 Continue to review full report at Codecov.
|
2 tasks
horizonzy
reviewed
Mar 11, 2021
Member
horizonzy
left a comment
There was a problem hiding this comment.
line_71 also follow this logic.
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/MergeableClusterInvoker.java
Outdated
Show resolved
Hide resolved
…he resultType of "resultList.iterator().next()" is AppResponse, which would throw an exception of UnsupportedOperationException
AlbumenJ
added a commit
to AlbumenJ/dubbo
that referenced
this pull request
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
to fix something wrong with MergeableClusterInvoker#7359
Brief changelog
As MergeableClusterInvoker was used, when 'resultList.size() == 1', there would be an error msg "AppResponse represents an concrete business response, there will be no status changes, you should get internal values directly." The reason is that the resultType would be "AppResponse", in org.apache.dubbo.rpc.cluster.support.wrapper.AbstractCluster.InterceptorInvokerNode#invoke method's "return clause" the exception would be thrown.
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.