Skip to content

fix deprecated import#7355

Merged
AlbumenJ merged 3 commits intoapache:masterfrom
me0106:patch-1
Mar 11, 2021
Merged

fix deprecated import#7355
AlbumenJ merged 3 commits intoapache:masterfrom
me0106:patch-1

Conversation

@me0106
Copy link
Copy Markdown

@me0106 me0106 commented Mar 10, 2021 •
edited
Loading

What is the purpose of the change

fix deprecated import: com.alibaba.dubbo.rpc.service.EchoService

@AlbumenJ
Copy link
Copy Markdown
Member

AlbumenJ commented Mar 10, 2021

@nan-lou thanks for your contribution

pls fix ut for EchoServiceTest

image

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 11, 2021

Codecov Report

Merging #7355 (e26929a) into master (e02be08) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7355      +/-   ##
============================================
- Coverage     58.67%   58.58%   -0.10%     
+ Complexity      426      424       -2     
============================================
  Files          1044     1044              
  Lines         42488    42442      -46     
  Branches       6231     6199      -32     
============================================
- Hits          24930    24864      -66     
- Misses        14760    14792      +32     
+ Partials       2798     2786      -12
Impacted Files Coverage Δ Complexity Δ
...g/apache/dubbo/rpc/proxy/AbstractProxyFactory.java 73.68% <ø> (ø) 0.00 <0.00> (ø)
...bbo/common/bytecode/CustomizedLoaderClassPath.java 28.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
.../registry/multicast/MulticastServiceDiscovery.java 38.46% <0.00%> (-7.70%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/fixed/FixedThreadPool.java 80.00% <0.00%> (-7.50%) 0.00% <0.00%> (ø%)
...moting/transport/netty4/NettyEventLoopFactory.java 30.00% <0.00%> (-6.37%) 0.00% <0.00%> (ø%)
.../threadpool/support/limited/LimitedThreadPool.java 83.33% <0.00%> (-5.56%) 0.00% <0.00%> (ø%)
...on/threadpool/support/cached/CachedThreadPool.java 85.71% <0.00%> (-4.29%) 0.00% <0.00%> (ø%)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02be08...e26929a. Read the comment docs.

AlbumenJ
AlbumenJ approved these changes Mar 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 30b02a4 into apache:master Mar 11, 2021
@me0106 me0106 deleted the patch-1 branch March 12, 2021 02:37
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
@AlbumenJ
Pick from apache#7355 30b02a4
731b6eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@me0106 @AlbumenJ @codecov-io