Skip to content

Some unit fix.#7354

Merged
AlbumenJ merged 1 commit intoapache:masterfrom
horizonzy:fix-nacos-timeout
Mar 10, 2021
Merged

Some unit fix.#7354
AlbumenJ merged 1 commit intoapache:masterfrom
horizonzy:fix-nacos-timeout

Conversation

@horizonzy
Copy link
Copy Markdown
Member

What is the purpose of the change

1.nacos getConfig timeout 300ms -> 3000ms.
2.ServiceInstanceMetadataUtils.refreshMetadataAndInstance() fixAtDealy 5000MICROSECONDS -> 5000MILLISECONDS

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 10, 2021

Codecov Report

Merging #7354 (e7c8393) into master (e02be08) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7354      +/-   ##
============================================
- Coverage     58.67%   58.62%   -0.06%     
+ Complexity      426      425       -1     
============================================
  Files          1044     1044              
  Lines         42488    42488              
  Branches       6231     6231              
============================================
- Hits          24930    24908      -22     
- Misses        14760    14785      +25     
+ Partials       2798     2795       -3     
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 42.02% <0.00%> (ø) 0.00 <0.00> (ø)
...ubbo/metadata/store/nacos/NacosMetadataReport.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
.../registry/multicast/MulticastServiceDiscovery.java 38.46% <0.00%> (-7.70%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...dubbo/remoting/exchange/support/DefaultFuture.java 84.61% <0.00%> (-3.42%) 0.00% <0.00%> (ø%)
...ubbo/registry/client/ServiceDiscoveryRegistry.java 47.64% <0.00%> (-2.36%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 94.23% <0.00%> (-1.93%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) 16.00% <0.00%> (ø%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02be08...e7c8393. Read the comment docs.

Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit a5859d1 into apache:master Mar 10, 2021
lucifer0x1 added a commit to lucifer0x1/dubbo that referenced this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants