Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7354 +/- ##
============================================
- Coverage 58.67% 58.62% -0.06%
+ Complexity 426 425 -1
============================================
Files 1044 1044
Lines 42488 42488
Branches 6231 6231
============================================
- Hits 24930 24908 -22
- Misses 14760 14785 +25
+ Partials 2798 2795 -3 Continue to review full report at Codecov.
|
lucifer0x1
added a commit
to lucifer0x1/dubbo
that referenced
this pull request
Mar 10, 2021
some unit fix about nacos (apache#7354)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
1.nacos getConfig timeout 300ms -> 3000ms.
2.ServiceInstanceMetadataUtils.refreshMetadataAndInstance() fixAtDealy 5000MICROSECONDS -> 5000MILLISECONDS