Skip to content

Super interface shouldn't import sub interface.#7279

Merged
AlbumenJ merged 3 commits intoapache:masterfrom
horizonzy:fix-code
Mar 11, 2021
Merged

Super interface shouldn't import sub interface.#7279
AlbumenJ merged 3 commits intoapache:masterfrom
horizonzy:fix-code

Conversation

@horizonzy
Copy link
Copy Markdown
Member

What is the purpose of the change

Code clean.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 27, 2021

Codecov Report

Merging #7279 (6facde2) into master (4ad2634) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7279      +/-   ##
============================================
+ Coverage     59.03%   59.04%   +0.01%     
- Complexity      461      462       +1     
============================================
  Files          1043     1043              
  Lines         42445    42445              
  Branches       6222     6222              
============================================
+ Hits          25057    25062       +5     
+ Misses        14587    14582       -5     
  Partials       2801     2801              
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/apache/dubbo/rpc/cluster/Cluster.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.36% <0.00%> (-9.10%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-3.41%) 19.00% <0.00%> (-1.00%)
...apache/dubbo/common/extension/ExtensionLoader.java 77.85% <0.00%> (-0.23%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) 31.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.52% <0.00%> (+0.95%) 17.00% <0.00%> (+1.00%)
...pache/dubbo/registry/support/AbstractRegistry.java 81.11% <0.00%> (+1.48%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/common/utils/ExecutorUtil.java 63.79% <0.00%> (+1.72%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 50.00% <0.00%> (+10.52%) 16.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad2634...6facde2. Read the comment docs.

Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 60a2244 into apache:master Mar 11, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants