Skip to content

improve dubbo cache and job depends#7147

Merged
AlbumenJ merged 3 commits intoapache:masterfrom
kylixs:improve-dubbo-cache
Jan 28, 2021
Merged

improve dubbo cache and job depends#7147
AlbumenJ merged 3 commits intoapache:masterfrom
kylixs:improve-dubbo-cache

Conversation

@kylixs
Copy link
Copy Markdown
Member

@kylixs kylixs commented Jan 28, 2021 •
edited
Loading

What is the purpose of the change

Fix dubbo cache being overwritten problem

Brief changelog

Merge dubbo cache and dubbo-spring-boot-project cache

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

kylixs and others added 2 commits January 28, 2021 18:32
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 28, 2021 •
edited
Loading

Codecov Report

Merging #7147 (8102db6) into master (02f236e) will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7147      +/-   ##
============================================
- Coverage     59.96%   59.70%   -0.27%     
+ Complexity      292      289       -3     
============================================
  Files          1001     1001              
  Lines         39957    39957              
  Branches       5935     5935              
============================================
- Hits          23962    23858     -104     
- Misses        13295    13394      +99     
- Partials       2700     2705       +5
Impacted Files Coverage Δ Complexity Δ
...figcenter/file/FileSystemDynamicConfiguration.java 31.42% <0.00%> (-31.43%) 0.00% <0.00%> (ø%)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty4/NettyClient.java 60.86% <0.00%> (-10.15%) 0.00% <0.00%> (ø%)
...o/remoting/transport/ChannelHandlerDispatcher.java 60.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) 19.00% <0.00%> (-2.00%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
...ubbo/registry/support/AbstractRegistryFactory.java 79.03% <0.00%> (-3.23%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/config/ServiceConfig.java 62.19% <0.00%> (-3.05%) 0.00% <0.00%> (ø%)
...fig/configcenter/TreePathDynamicConfiguration.java 77.14% <0.00%> (-2.86%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/AbortPolicyWithReport.java 95.00% <0.00%> (-2.50%) 0.00% <0.00%> (ø%)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02f236e...8102db6. Read the comment docs.

AlbumenJ
AlbumenJ approved these changes Jan 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit b429763 into apache:master Jan 28, 2021
kylixs added a commit to kylixs/dubbo that referenced this pull request Jan 29, 2021
@kylixs @AlbumenJ
improve dubbo cache and job depends (apache#7147)
8c65913 
* improve dubbo cache and job depends

* Improve dubbo cache (#1)

Merge Dubbo-Spring-Boot build with Dubbo

* improve dubbo version

Co-authored-by: Albumen Kevin <jhq0812@gmail.com>
(cherry picked from commit b429763)
@kylixs kylixs deleted the improve-dubbo-cache branch October 23, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kylixs @codecov-io @AlbumenJ