Skip to content

Optimize code#7070

Merged
ralf0131 merged 2 commits intoapache:masterfrom
github-ganyu:master
Jan 4, 2021
Merged

Optimize code#7070
ralf0131 merged 2 commits intoapache:masterfrom
github-ganyu:master

Conversation

@github-ganyu
Copy link
Copy Markdown

@github-ganyu github-ganyu commented Dec 31, 2020 •
edited
Loading

What is the purpose of the change

Simplify the code

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@github-ganyu
Copy link
Copy Markdown
Author

github-ganyu commented Dec 31, 2020

When I looked at the dubbo source found this code, can be simplified.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 1, 2021 •
edited
Loading

Codecov Report

Merging #7070 (bdb4173) into master (d98d489) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7070      +/-   ##
============================================
- Coverage     59.36%   59.15%   -0.21%     
  Complexity      507      507              
============================================
  Files          1028     1028              
  Lines         41527    41525       -2     
  Branches       6038     6038              
============================================
- Hits          24651    24564      -87     
- Misses        14123    14195      +72     
- Partials       2753     2766      +13
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/registry/nacos/NacosRegistry.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 0.00% <0.00%> (-46.16%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-34.49%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/AbortPolicyWithReport.java 85.00% <0.00%> (-12.50%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0.00%> (-10.17%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 78.63% <0.00%> (-7.70%) 0.00% <0.00%> (ø%)
...apache/dubbo/common/config/ConfigurationUtils.java 58.62% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.38% <0.00%> (-5.95%) 0.00% <0.00%> (ø%)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98d489...bdb4173. Read the comment docs.

ralf0131
ralf0131 approved these changes Jan 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request.

@ralf0131 ralf0131 merged commit 70b6fb3 into apache:master Jan 4, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 26, 2021
@AlbumenJ
Pick from apache#7070 70b6fb3
45f644a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralf0131 ralf0131 ralf0131 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@github-ganyu @codecov-io @ralf0131