Skip to content

[Unit Test] Fix error in PublishingServiceDefinitionListenerTest#6983

Merged
htynkn merged 1 commit intoapache:masterfrom
AlbumenJ:fix/ut
Dec 18, 2020
Merged

[Unit Test] Fix error in PublishingServiceDefinitionListenerTest#6983
htynkn merged 1 commit intoapache:masterfrom
AlbumenJ:fix/ut

Conversation

@AlbumenJ
Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ commented Dec 3, 2020

What is the purpose of the change

  • Add ApplicationModel reset before test case.

The reason is new version of environment will cause order difference of test cases, and some test cases will pollute the static environment like ApplicationModel and Spring.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 3, 2020

Codecov Report

Merging #6983 (148b356) into master (3fc2d10) will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6983      +/-   ##
============================================
- Coverage     59.44%   59.18%   -0.26%     
+ Complexity      511      507       -4     
============================================
  Files          1028     1028              
  Lines         41519    41519              
  Branches       6037     6037              
============================================
- Hits          24679    24575     -104     
- Misses        14104    14176      +72     
- Partials       2736     2768      +32     
Impacted Files Coverage Δ Complexity Δ
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-27.59%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/AbortPolicyWithReport.java 85.00% <0.00%> (-12.50%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0.00%> (-10.17%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 78.63% <0.00%> (-9.41%) 0.00% <0.00%> (ø%)
...apache/dubbo/common/config/ConfigurationUtils.java 58.62% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
...g/p2p/exchange/support/MulticastExchangeGroup.java 77.50% <0.00%> (-5.00%) 0.00% <0.00%> (ø%)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc2d10...148b356. Read the comment docs.

@htynkn htynkn merged commit d288ff1 into apache:master Dec 18, 2020
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants