[Dubbo-AbstractConfig] Fix password be print in plain text#6931
Merged
AlbumenJ merged 2 commits intoapache:masterfrom Apr 12, 2021
Merged
[Dubbo-AbstractConfig] Fix password be print in plain text#6931AlbumenJ merged 2 commits intoapache:masterfrom
AlbumenJ merged 2 commits intoapache:masterfrom
Conversation
Hidden the important password information to avoid be printed in plain text into the logger file
Author
|
Issue is here |
Codecov Report
@@ Coverage Diff @@
## master #6931 +/- ##
============================================
- Coverage 59.44% 59.26% -0.18%
+ Complexity 511 504 -7
============================================
Files 1028 1028
Lines 41519 41519
Branches 6037 6022 -15
============================================
- Hits 24679 24605 -74
- Misses 14104 14157 +53
- Partials 2736 2757 +21 Continue to review full report at Codecov.
|
change == to equals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Hidden the important password information to avoid be printed in plain text into the logger file
Brief changelog
Update AbstractConfig.java
hidden password
Verifying this change
The registry[<dubbo:registry password="******" username="someone" timeout="10000" group="test" client="curator" address="127.0.0.1" protocol="zookeeper" port="2181" />] will be used as the config center, dubbo version: 2.7.8, current host: 127.0.0.1Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.