[ISSUE-#6908] Extract AccessibleObject.setAccessible(boolean) to ReflectUtils#6909
Merged
AlbumenJ merged 7 commits intoapache:masterfrom Mar 11, 2021
Merged
[ISSUE-#6908] Extract AccessibleObject.setAccessible(boolean) to ReflectUtils#6909AlbumenJ merged 7 commits intoapache:masterfrom
AlbumenJ merged 7 commits intoapache:masterfrom
Conversation
Member
Author
|
@htynkn Hi, I notice project call AccessibleObject.setAccessible(boolean) somewhere, it should be extract unifiedly in ReflectUtils。 |
Codecov Report
@@ Coverage Diff @@
## master #6909 +/- ##
============================================
- Coverage 59.05% 59.02% -0.04%
Complexity 463 463
============================================
Files 1044 1043 -1
Lines 42485 42475 -10
Branches 6230 6219 -11
============================================
- Hits 25091 25069 -22
- Misses 14592 14609 +17
+ Partials 2802 2797 -5
Continue to review full report at Codecov.
|
Member
|
lgtm |
Member
Author
Thanks for your review. |
…ReflectUtils.makeAccess
# Conflicts: # dubbo-common/src/main/java/org/apache/dubbo/common/utils/ReflectUtils.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
For-#6908