Skip to content

[ISSUE-#6904] Fix reflect invoke error in org.apache.dubbo.common.utils.PojoUtils#generalize#6905

Merged
AlbumenJ merged 3 commits intoapache:masterfrom
horizonzy:fix-pojoUtils-reflect-invoke
Mar 6, 2021
Merged

[ISSUE-#6904] Fix reflect invoke error in org.apache.dubbo.common.utils.PojoUtils#generalize#6905
AlbumenJ merged 3 commits intoapache:masterfrom
horizonzy:fix-pojoUtils-reflect-invoke

Conversation

@horizonzy
Copy link
Copy Markdown
Member

@horizonzy horizonzy commented Nov 13, 2020

What is the purpose of the change

Fix-#6904

@horizonzy
Copy link
Copy Markdown
Member Author

horizonzy commented Nov 13, 2020

@htynkn Hi, there is a bug need to check.

@htynkn htynkn added the type/need-triage Need maintainers to triage label Nov 13, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 14, 2020 •
edited
Loading

Codecov Report

Merging #6905 (27bdd55) into master (eef6b45) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6905      +/-   ##
============================================
- Coverage     59.06%   59.02%   -0.04%     
- Complexity      462      463       +1     
============================================
  Files          1044     1044              
  Lines         42480    42485       +5     
  Branches       6229     6230       +1     
============================================
- Hits          25090    25078      -12     
- Misses        14591    14603      +12     
- Partials       2799     2804       +5
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/dubbo/common/utils/ReflectUtils.java 70.42% <ø> (-0.14%) 0.00 <0.00> (ø)
.../java/org/apache/dubbo/common/utils/PojoUtils.java 73.17% <100.00%> (+0.07%) 0.00 <0.00> (ø)
.../registry/multicast/MulticastServiceDiscovery.java 38.46% <0.00%> (-7.70%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 85.47% <0.00%> (-2.57%) 0.00% <0.00%> (ø%)
...he/dubbo/rpc/protocol/hessian/HessianProtocol.java 67.46% <0.00%> (-2.41%) 9.00% <0.00%> (ø%)
...ubbo/registry/client/ServiceDiscoveryRegistry.java 47.64% <0.00%> (-2.36%) 0.00% <0.00%> (ø%)
.../dubbo/registry/integration/RegistryDirectory.java 75.50% <0.00%> (-1.01%) 0.00% <0.00%> (ø%)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.12% <0.00%> (-0.93%) 0.00% <0.00%> (ø%)
...org/apache/dubbo/registry/redis/RedisRegistry.java 49.21% <0.00%> (-0.79%) 28.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 79.62% <0.00%> (-0.38%) 0.00% <0.00%> (ø%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef6b45...27bdd55. Read the comment docs.

@horizonzy horizonzy mentioned this pull request Dec 4, 2020
Merged
AlbumenJ
AlbumenJ approved these changes Mar 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 2062cdb into apache:master Mar 6, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
@AlbumenJ
Pick from apache#6905 2062cdb
bc5c7c0
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.02%. Comparing base (eef6b45) to head (27bdd55).

Files with missing lines Patch % Lines
...va/org/apache/dubbo/common/utils/ReflectUtils.java 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6905      +/-   ##
============================================
- Coverage     59.06%   59.02%   -0.04%     
- Complexity      462      463       +1     
============================================
  Files          1044     1044              
  Lines         42480    42485       +5     
  Branches       6229     6230       +1     
============================================
- Hits          25090    25078      -12     
- Misses        14591    14603      +12     
- Partials       2799     2804       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees

No one assigned

Labels

type/need-triage Need maintainers to triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@horizonzy @codecov-io @codecov-commenter @AlbumenJ @htynkn