Skip to content

[Dubbo] Proofread CONTRIBUTING.md file with multiple fixes#6805

Merged
ralf0131 merged 1 commit intoapache:masterfrom
royadityak94:patch-1
Oct 15, 2020
Merged

[Dubbo] Proofread CONTRIBUTING.md file with multiple fixes#6805
ralf0131 merged 1 commit intoapache:masterfrom
royadityak94:patch-1

Conversation

@royadityak94
Copy link
Copy Markdown

Fixed typo, grammatical, punctuations, and semantic coherence to improve readability and content quality.

What is the purpose of the change

To improve the readability, content quality of the CONTRIBUTING.md file.

Brief changelog

Fixed typo, grammatical, punctuations, and semantic coherence.

Verifying this change

Doesn't impact the main codebase, and is entirely limited to the CONTRIBUTING.md file.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Fixed typo, grammatical, punctuations, and semantic coherence to improve readability and content quality.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 15, 2020

Codecov Report

Merging #6805 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6805      +/-   ##
============================================
- Coverage     59.11%   59.07%   -0.05%     
+ Complexity      509      506       -3     
============================================
  Files          1028     1028              
  Lines         41522    41522              
  Branches       6039     6039              
============================================
- Hits          24547    24529      -18     
- Misses        14203    14217      +14     
- Partials       2772     2776       +4     
Impacted Files Coverage Δ Complexity Δ
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) 19.00% <0.00%> (-2.00%)
.../registry/multicast/MulticastServiceDiscovery.java 23.07% <0.00%> (-7.70%) 0.00% <0.00%> (ø%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 77.77% <0.00%> (-2.97%) 0.00% <0.00%> (ø%)
...ubbo/registry/client/ServiceDiscoveryRegistry.java 27.84% <0.00%> (-2.54%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (-0.96%) 16.00% <0.00%> (-1.00%)
...ava/org/apache/dubbo/config/ServiceConfigBase.java 53.17% <0.00%> (-0.58%) 0.00% <0.00%> (ø%)
...n/java/org/apache/dubbo/common/utils/NetUtils.java 66.55% <0.00%> (+0.34%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) 31.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d06e5e...2267658. Read the comment docs.

@royadityak94
Copy link
Copy Markdown
Author

@ralf0131, @htynkn: Can I request you to review my changes and merge them into the master branch.

@ralf0131 ralf0131 merged commit 78ce240 into apache:master Oct 15, 2020
chickenlj pushed a commit to chickenlj/incubator-dubbo that referenced this pull request Nov 25, 2020
Fixed typo, grammatical, punctuations, and semantic coherence to improve readability and content quality.
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants