Skip to content

[Dubbo-6749] optimize : constant names should be all uppercase#6760

Merged
AlbumenJ merged 1 commit intoapache:masterfrom
gzldc:master
Mar 14, 2021
Merged

[Dubbo-6749] optimize : constant names should be all uppercase#6760
AlbumenJ merged 1 commit intoapache:masterfrom
gzldc:master

Conversation

@gzldc
Copy link
Copy Markdown

@gzldc gzldc commented Sep 17, 2020

What is the purpose of the change

fix #6749

Brief changelog

Brief changelog:
1.dubbo-common/src/test/java/org/apache/dubbo/common/config/configcenter/ConfigChangedEventTest.java
2.dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/registry/MockRegistryFactory.java

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a #6749 field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@gzldc gzldc changed the title 【dubbo-6749】optimize : constant names should be all uppercase [dubbo-6749] optimize : constant names should be all uppercase Sep 17, 2020
@gzldc gzldc changed the title [dubbo-6749] optimize : constant names should be all uppercase [Dubbo-6749] optimize : constant names should be all uppercase Sep 17, 2020
Copy link
Copy Markdown
Author

@gzldc gzldc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These modifications will not affect performance, but are more standardized.

@AlbumenJ
Copy link
Copy Markdown
Member

AlbumenJ commented Oct 2, 2020

fine, this will make source code more readable!

@AlbumenJ AlbumenJ merged commit 97cb435 into apache:master Mar 14, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

optimize : constant names should be all uppercase

2 participants