Skip to content

[dubbo-6756]ssl support load from classpath#6756

Merged
AlbumenJ merged 4 commits intoapache:masterfrom
owen200008:support_ssl_load_from_classpath
Mar 11, 2021
Merged

[dubbo-6756]ssl support load from classpath#6756
AlbumenJ merged 4 commits intoapache:masterfrom
owen200008:support_ssl_load_from_classpath

Conversation

@owen200008
Copy link
Copy Markdown
Contributor

@owen200008 owen200008 commented Sep 17, 2020 •
edited
Loading

What is the purpose of the change

ssl support load from classpath

Brief changelog

add getURL function like spring

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@owen200008 owen200008 changed the title ssl support load from classpath [dubbo-6756]ssl support load from classpath Sep 17, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #6756 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6756      +/-   ##
============================================
- Coverage     58.83%   58.76%   -0.08%     
+ Complexity      507      506       -1     
============================================
  Files          1026     1026              
  Lines         41383    41397      +14     
  Branches       6028     6031       +3     
============================================
- Hits          24348    24327      -21     
- Misses        14274    14305      +31     
- Partials       2761     2765       +4
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...in/java/org/apache/dubbo/common/utils/IOUtils.java 65.45% <0.00%> (-22.36%) 0.00 <0.00> (ø)
...c/main/java/org/apache/dubbo/config/SslConfig.java 19.29% <0.00%> (ø) 0.00 <0.00> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/AbortPolicyWithReport.java 85.00% <0.00%> (-5.00%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-3.41%) 19.00% <0.00%> (-1.00%)
...pache/dubbo/registry/support/AbstractRegistry.java 77.69% <0.00%> (-2.98%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.00% <0.00%> (-0.59%) 31.00% <0.00%> (ø%)
...figcenter/file/FileSystemDynamicConfiguration.java 62.38% <0.00%> (-0.48%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.10% <0.00%> (-0.35%) 0.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a568518...b1833ab. Read the comment docs.

AlbumenJ
AlbumenJ approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 5602191 into apache:master Mar 11, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
@AlbumenJ
Pick from apache#6756 5602191
bd6c3aa
@owen200008 owen200008 deleted the support_ssl_load_from_classpath branch August 18, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@owen200008 @codecov-commenter @AlbumenJ