[Dubbo-6733] multicast use valid network interface#6734
Merged
AlbumenJ merged 1 commit intoapache:masterfrom Mar 11, 2021
Merged
[Dubbo-6733] multicast use valid network interface#6734AlbumenJ merged 1 commit intoapache:masterfrom
AlbumenJ merged 1 commit intoapache:masterfrom
Conversation
Member
|
@AlphaLxy could you please merge the latest master branch into this pr so we can check if the integration test work well. |
bb9b96f to
93d6c73
Compare
Codecov Report
@@ Coverage Diff @@
## master #6734 +/- ##
============================================
- Coverage 58.67% 58.56% -0.12%
+ Complexity 425 424 -1
============================================
Files 1044 1044
Lines 42484 42482 -2
Branches 6229 6212 -17
============================================
- Hits 24928 24878 -50
- Misses 14759 14802 +43
- Partials 2797 2802 +5 Continue to review full report at Codecov.
|
Author
rebase and force pushed |
AlbumenJ
added a commit
to AlbumenJ/dubbo
that referenced
this pull request
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix #6733, multicast use valid network interface
Brief changelog
MulticastSocket should use a valid network interface, use
getValidNetworkInterfacesinstead ofNetworkInterface.getNetworkInterfaces.Just modified
dubbo-common/src/main/java/org/apache/dubbo/common/utils/NetUtils.javaVerifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.