Codecov Report

Merging #6726 into master will increase coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6726      +/-   ##
============================================
+ Coverage     58.84%   59.07%   +0.22%     
+ Complexity      508      507       -1     
============================================
  Files          1025     1025              
  Lines         41341    41341              
  Branches       6014     6014              
============================================
+ Hits          24326    24421      +95     
+ Misses        14262    14187      -75     
+ Partials       2753     2733      -20     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a466f4f...1b45131. Read the comment docs.

Changes looks good to me.

but there are few things need to be discuss before merge it:

• are we going to disable travis-ci (it doesn't make sense to have both them, it will waste resource and time)
• what platform do we use? I prefer linux-jdk8 and linux-jdk11. maybe windows too. but for macos, the lack of action runner will lead a long time to wait
• different concurrency limit between github action and travis ci (refer to https://www.mail-archive.com/builds@apache.org/msg07478.html)

hi, @htynkn

what platform do we use? I prefer linux-jdk8 and linux-jdk11. maybe windows too. but for macos, the lack of action runner will lead a long time to wait

yeap, I agree with you. I will disable macOS test case later on.

different concurrency limit between github action and travis ci (refer to https://www.mail-archive.com/builds@apache.org/msg07478.html)

According to Github Community, we can use at least up to 20 workflows concurrently for dubbo repo itself. For now it is enough for our building rate on travis.

Codecov Report

Merging #6726 (6337c5c) into master (a2a14dc) will increase coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6726      +/-   ##
============================================
+ Coverage     59.09%   59.32%   +0.23%     
+ Complexity      509      508       -1     
============================================
  Files          1028     1028              
  Lines         41519    41519              
  Branches       6037     6021      -16     
============================================
+ Hits          24536    24633      +97     
+ Misses        14211    14136      -75     
+ Partials       2772     2750      -22     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a14dc...6337c5c. Read the comment docs.

DirtiesContext has been added to all of the test classes in dubbo-config-spring module. In different platform, the exection order of test cases is different and this may causes environment pollution. DirtiesContext can fix it.