Skip to content

add short/byte data type support for PojoUtils#getDefaultValue#6551

Merged
htynkn merged 2 commits intoapache:masterfrom
horizonzy:serial-fix
Nov 12, 2020
Merged

add short/byte data type support for PojoUtils#getDefaultValue#6551
htynkn merged 2 commits intoapache:masterfrom
horizonzy:serial-fix

Conversation

@horizonzy
Copy link
Copy Markdown
Member

@horizonzy horizonzy commented Aug 4, 2020 •
edited by htynkn
Loading

What is the purpose of the change

close #6550

@AlbumenJ
Copy link
Copy Markdown
Member

AlbumenJ commented Aug 22, 2020

LGTM

@horizonzy horizonzy mentioned this pull request Nov 12, 2020
Merged
6 tasks
@htynkn htynkn changed the title [ISSUE-6550]. fix PojoUtils.realize error mentioned #6550 add short/byte data type support for PojoUtils#getDefaultValue Nov 12, 2020
@htynkn htynkn added status/READY-TO-MERGE type/bug Bugs to being fixed labels Nov 12, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 12, 2020

Codecov Report

Merging #6551 (3e7026d) into master (b14e534) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6551      +/-   ##
============================================
+ Coverage     59.02%   59.08%   +0.05%     
- Complexity      504      508       +4     
============================================
  Files          1028     1028              
  Lines         41515    41519       +4     
  Branches       6019     6037      +18     
============================================
+ Hits          24505    24531      +26     
+ Misses        14235    14214      -21     
+ Partials       2775     2774       -1
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/common/utils/PojoUtils.java 72.31% <100.00%> (+0.30%) 0.00 <0.00> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.00% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 77.77% <0.00%> (-0.86%) 0.00% <0.00%> (ø%)
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.81% <0.00%> (-0.40%) 27.00% <0.00%> (-1.00%)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 42.03% <0.00%> (-0.17%) 0.00% <0.00%> (ø%)
...che/dubbo/common/compiler/support/JdkCompiler.java 63.20% <0.00%> (ø) 0.00% <0.00%> (ø%)
...apache/dubbo/common/extension/ExtensionLoader.java 75.56% <0.00%> (+0.22%) 0.00% <0.00%> (ø%)
...ubbo/registry/client/ServiceDiscoveryRegistry.java 27.84% <0.00%> (+0.63%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.52% <0.00%> (+0.95%) 17.00% <0.00%> (+1.00%)
...ache/dubbo/common/compiler/support/ClassUtils.java 50.26% <0.00%> (+1.04%) 0.00% <0.00%> (ø%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b14e534...3e7026d. Read the comment docs.

@htynkn htynkn merged commit a2a14dc into apache:master Nov 12, 2020
chickenlj pushed a commit to chickenlj/incubator-dubbo that referenced this pull request Nov 25, 2020
@horizonzy @chickenlj
add short/byte data type support for PojoUtils#getDefaultValue (apach…
6e2f6a7 
…e#6551)
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 26, 2021
@AlbumenJ
Pick from apache#6551 a2a14dc
858c9d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@htynkn htynkn htynkn approved these changes

Assignees

No one assigned

Labels

type/bug Bugs to being fixed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

org.apache.dubbo.common.utils.PojoUtils#realize problem.

4 participants

@horizonzy @AlbumenJ @codecov-io @htynkn