Skip to content

fix redundant code#6347

Merged
AlbumenJ merged 1 commit intoapache:masterfrom
bbq217:fix_redundant_code
Mar 14, 2021
Merged

fix redundant code#6347
AlbumenJ merged 1 commit intoapache:masterfrom
bbq217:fix_redundant_code

Conversation

@bbq217
Copy link
Copy Markdown

@bbq217 bbq217 commented Jun 19, 2020

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@htynkn
Copy link
Copy Markdown
Member

htynkn commented Jun 22, 2020

could you provide some detail about this PR?

@bbq217
Copy link
Copy Markdown
Author

bbq217 commented Jun 23, 2020

could you provide some detail about this PR?

two_condition

The second condition is uesless. Two conditions from different branches to solve same bug.

@htynkn htynkn added status/feedback-provided and removed status/waiting-for-feedback Need reporters to triage labels Jun 24, 2020
@AlbumenJ AlbumenJ merged commit 829eb19 into apache:master Mar 14, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants