Skip to content

fix object attachments iteration bug#6210

Merged
qinliujie merged 1 commit intoapache:masterfrom
chickenlj:fix-object-attachment-iteration
May 27, 2020
Merged

fix object attachments iteration bug#6210
qinliujie merged 1 commit intoapache:masterfrom
chickenlj:fix-object-attachment-iteration

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

No description provided.

@chickenlj chickenlj mentioned this pull request May 25, 2020
6 tasks
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #6210 into master will decrease coverage by 0.06%.
The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6210      +/-   ##
============================================
- Coverage     60.90%   60.84%   -0.07%     
+ Complexity      494      492       -2     
============================================
  Files           999      999              
  Lines         39898    39979      +81     
  Branches       5744     5775      +31     
============================================
+ Hits          24301    24324      +23     
- Misses        12907    12949      +42     
- Partials       2690     2706      +16     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/rpc/AttachmentsAdapter.java 50.00% <38.46%> (+21.42%) 0.00 <0.00> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 52.17% <0.00%> (-10.87%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 63.82% <0.00%> (-10.64%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) 19.00% <0.00%> (-2.00%)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 74.35% <0.00%> (-4.28%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2f6af...b51f110. Read the comment docs.

@qinliujie
Copy link
Copy Markdown
Contributor

LGTM

@qinliujie qinliujie merged commit 21e11e7 into apache:master May 27, 2020
vergilyn pushed a commit to vergilyn/dubbo-fork that referenced this pull request May 28, 2020
* fix object attachments iteration bug

(cherry picked from commit 21e11e7)
@chickenlj chickenlj deleted the fix-object-attachment-iteration branch September 4, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants