Skip to content

[Enhancement] Improve code coverage and fix some code#6197

Merged
chickenlj merged 15 commits intoapache:masterfrom
AlbumenJ:common-test
Jan 13, 2021
Merged

[Enhancement] Improve code coverage and fix some code#6197
chickenlj merged 15 commits intoapache:masterfrom
AlbumenJ:common-test

Conversation

@AlbumenJ
Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ commented May 20, 2020

What is the purpose of the change

Brief changelog

  • perfect test cases in dubbo-common
  • perfect test cases in dubbo-remote
  • add RunnableWrapper to manage exception in ThreadlessExecutor
  • fix empty check in StatusTelnetHandler

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2020

Codecov Report

Merging #6197 into master will increase coverage by 0.85%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6197      +/-   ##
============================================
+ Coverage     60.87%   61.73%   +0.85%     
  Complexity      492      492              
============================================
  Files           999      999              
  Lines         39897    39904       +7     
  Branches       5748     5744       -4     
============================================
+ Hits          24286    24633     +347     
+ Misses        12917    12573     -344     
- Partials       2694     2698       +4     
Impacted Files Coverage Δ Complexity Δ
...a/org/apache/dubbo/common/BaseServiceMetadata.java 97.87% <100.00%> (+48.93%) 0.00 <0.00> (ø)
...ain/java/org/apache/dubbo/common/URLStrParser.java 87.42% <100.00%> (+9.58%) 0.00 <0.00> (ø)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 94.23% <100.00%> (+31.18%) 0.00 <0.00> (ø)
...ng/telnet/support/command/StatusTelnetHandler.java 84.09% <100.00%> (+84.09%) 0.00 <0.00> (ø)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/rpc/TimeoutCountDown.java 0.00% <0.00%> (-18.75%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/rpc/filter/TimeoutFilter.java 35.71% <0.00%> (-14.29%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 63.82% <0.00%> (-10.64%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/rpc/support/RpcUtils.java 53.63% <0.00%> (-5.46%) 0.00% <0.00%> (ø%)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3316b...43032e3. Read the comment docs.

@chickenlj chickenlj merged commit bd43fa7 into apache:master Jan 13, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] ThreadlessExecutor unable to handle all exceptions [Bugfix] Telnet unable get proper health when execute 'status' without parameter

3 participants