Skip to content

fix unit test for qos module#5962

Merged
htynkn merged 1 commit intoapache:masterfrom
htynkn:chore/fix-ci-0402
Apr 2, 2020
Merged

fix unit test for qos module#5962
htynkn merged 1 commit intoapache:masterfrom
htynkn:chore/fix-ci-0402

Conversation

@htynkn
Copy link
Copy Markdown
Member

@htynkn htynkn commented Apr 2, 2020

What is the purpose of the change

Fix unit test issue for #5935

Brief changelog

Verifying this change

CI pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@htynkn htynkn merged commit b60acc5 into apache:master Apr 2, 2020
@htynkn htynkn deleted the chore/fix-ci-0402 branch April 2, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant