Skip to content

[Feature]Add version command in qos module#5935

Merged
chickenlj merged 3 commits intoapache:masterfrom
laddcn:20200328_qos_add_version_command
Apr 1, 2020
Merged

[Feature]Add version command in qos module#5935
chickenlj merged 3 commits intoapache:masterfrom
laddcn:20200328_qos_add_version_command

Conversation

@laddcn
Copy link
Copy Markdown
Contributor

@laddcn laddcn commented Mar 28, 2020

What is the purpose of the change

When using dubbo, developers always need to get dubbo version to debug online problems. And some popular RPC support command to get RPC version like brpc. So I add version command in qos module.

Brief changelog

Add version command in qos module

Verifying this change

When telnet to port of QOS, dubbo version description like "dubbo version "2.7.6" " will return when typing command "version".

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj chickenlj merged commit f3d57cd into apache:master Apr 1, 2020
@htynkn htynkn mentioned this pull request Apr 2, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants