Skip to content

fix typo in JEtcdClient#5834

Merged
tswstarplanet merged 1 commit intoapache:masterfrom
GungnirLaevatain:fixTypo
Mar 8, 2020
Merged

fix typo in JEtcdClient#5834
tswstarplanet merged 1 commit intoapache:masterfrom
GungnirLaevatain:fixTypo

Conversation

@GungnirLaevatain
Copy link
Copy Markdown
Contributor

@GungnirLaevatain GungnirLaevatain commented Mar 6, 2020

What is the purpose of the change

fix typo

Brief changelog

fix typo in org.apache.dubbo.remoting.etcd.jetcd.JEtcdClient

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 6, 2020

Codecov Report

Merging #5834 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5834      +/-   ##
============================================
- Coverage     61.22%   61.21%   -0.01%     
- Complexity      495      497       +2     
============================================
  Files           981      981              
  Lines         39137    39137              
  Branches       5644     5644              
============================================
- Hits          23960    23959       -1     
- Misses        12537    12542       +5     
+ Partials       2640     2636       -4
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java 9.63% <ø> (ø) 0 <0> (ø) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.06% <0%> (-2.98%) 0% <0%> (ø)
...etadata/report/support/AbstractMetadataReport.java 65.32% <0%> (-1.51%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.73% <0%> (+0.62%) 30% <0%> (ø) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 59.09% <0%> (+2.27%) 0% <0%> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.68% <0%> (+3.5%) 9% <0%> (+1%) ⬆️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 46.15% <0%> (+7.69%) 0% <0%> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 50% <0%> (+10.52%) 16% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b92414...bad10a0. Read the comment docs.

@tswstarplanet
Copy link
Copy Markdown
Contributor

tswstarplanet commented Mar 8, 2020

LGTM

@tswstarplanet tswstarplanet merged commit 4037b5d into apache:master Mar 8, 2020
chickenlj pushed a commit that referenced this pull request Mar 10, 2020
@GungnirLaevatain @chickenlj
fix typo (#5834)
e0ff2ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GungnirLaevatain @codecov-io @tswstarplanet