Skip to content

callback onError#5828

Merged
chickenlj merged 1 commit intoapache:masterfrom
haiyang1985:onError
Mar 4, 2020
Merged

callback onError#5828
chickenlj merged 1 commit intoapache:masterfrom
haiyang1985:onError

Conversation

@haiyang1985
Copy link
Copy Markdown
Member

@haiyang1985 haiyang1985 commented Mar 4, 2020

Fix Issue: #5827

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj chickenlj added this to the 2.7.7 milestone Mar 4, 2020
@chickenlj chickenlj merged commit cb5c576 into apache:master Mar 4, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 4, 2020

Codecov Report

Merging #5828 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5828      +/-   ##
============================================
+ Coverage     61.27%   61.29%   +0.01%     
  Complexity      498      498              
============================================
  Files           981      981              
  Lines         39142    39143       +1     
  Branches       5644     5644              
============================================
+ Hits          23985    23991       +6     
- Misses        12526    12529       +3     
+ Partials       2631     2623       -8
Impacted Files Coverage Δ Complexity Δ
.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java 20.61% <100%> (+2.91%) 0 <0> (ø) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 59.32% <0%> (-5.09%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0%> (-3.51%) 8% <0%> (-1%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.06% <0%> (-2.98%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.1% <0%> (-0.35%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 68.96% <0%> (ø) 0% <0%> (ø) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.52% <0%> (+0.95%) 17% <0%> (+1%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 68.31% <0%> (+1.98%) 0% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72b3b2...265222b. Read the comment docs.

chickenlj pushed a commit that referenced this pull request Mar 10, 2020
@haiyang1985 @chickenlj
call onThrowable when RPC call fail (#5828)
5a6a543 
fixes  #5827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.7.7

Development

Successfully merging this pull request may close these issues.

3 participants

@haiyang1985 @codecov-io @chickenlj