Skip to content

extracting duplicate code in CountTelnetHandler#5824

Merged
htynkn merged 1 commit intoapache:masterfrom
GungnirLaevatain:polish
Mar 5, 2020
Merged

extracting duplicate code in CountTelnetHandler#5824
htynkn merged 1 commit intoapache:masterfrom
GungnirLaevatain:polish

Conversation

@GungnirLaevatain
Copy link
Copy Markdown
Contributor

@GungnirLaevatain GungnirLaevatain commented Mar 4, 2020

What is the purpose of the change

extracting duplicate code in CountTelnetHandler

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 4, 2020

Codecov Report

Merging #5824 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5824      +/-   ##
============================================
- Coverage     61.27%   61.21%   -0.07%     
+ Complexity      498      497       -1     
============================================
  Files           981      981              
  Lines         39142    39088      -54     
  Branches       5644     5611      -33     
============================================
- Hits          23985    23928      -57     
- Misses        12526    12542      +16     
+ Partials       2631     2618      -13
Impacted Files Coverage Δ Complexity Δ
...rg/apache/dubbo/qos/legacy/CountTelnetHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 30.76% <0%> (-15.39%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0%> (-10.53%) 15% <0%> (-1%)
...mmon/threadpool/support/fixed/FixedThreadPool.java 80% <0%> (-7.5%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0%> (-6.9%) 0% <0%> (ø)
...moting/transport/netty4/NettyEventLoopFactory.java 30% <0%> (-6.37%) 0% <0%> (ø)
.../threadpool/support/limited/LimitedThreadPool.java 83.33% <0%> (-5.56%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 59.32% <0%> (-5.09%) 0% <0%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72b3b2...ed5dfc2. Read the comment docs.

@htynkn htynkn merged commit 7b92414 into apache:master Mar 5, 2020
@GungnirLaevatain GungnirLaevatain deleted the polish branch March 5, 2020 15:42
chickenlj pushed a commit that referenced this pull request Mar 10, 2020
@htynkn @chickenlj
extracting duplicate code in CountTelnetHandler (#5824)
a972650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@htynkn htynkn htynkn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GungnirLaevatain @codecov-io @htynkn