Skip to content

[Dubbo-5690]fix wrong telnet command package#5815

Merged
CrazyHZM merged 1 commit intoapache:masterfrom
xylsh:qos-telnet
Mar 7, 2020
Merged

[Dubbo-5690]fix wrong telnet command package#5815
CrazyHZM merged 1 commit intoapache:masterfrom
xylsh:qos-telnet

Conversation

@xylsh
Copy link
Copy Markdown
Contributor

@xylsh xylsh commented Feb 28, 2020

What is the purpose of the change

fixed #5690

Brief changelog

fix wrong telnet command package in META-INF/dubbo/internal/org.apache.dubbo.remoting.telnet.TelnetHandler

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@xylsh xylsh changed the title fix wrong telnet command package(#5690) [Dubbo-5690]fix wrong telnet command package Feb 28, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 28, 2020

Codecov Report

Merging #5815 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5815      +/-   ##
============================================
- Coverage     61.18%   61.17%   -0.01%     
+ Complexity      497      495       -2     
============================================
  Files           981      981              
  Lines         39143    39095      -48     
  Branches       5644     5611      -33     
============================================
- Hits          23948    23915      -33     
+ Misses        12567    12555      -12     
+ Partials       2628     2625       -3
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/remoting/transport/AbstractChannel.java 37.5% <0%> (-50%) 0% <0%> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0%> (-30.77%) 0% <0%> (ø)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0%> (-11.12%) 0% <0%> (ø)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 39.13% <0%> (-8.7%) 0% <0%> (ø)
...mmon/threadpool/support/fixed/FixedThreadPool.java 80% <0%> (-7.5%) 0% <0%> (ø)
...moting/transport/netty4/NettyEventLoopFactory.java 30% <0%> (-6.37%) 0% <0%> (ø)
.../threadpool/support/limited/LimitedThreadPool.java 83.33% <0%> (-5.56%) 0% <0%> (ø)
...on/threadpool/support/cached/CachedThreadPool.java 85.71% <0%> (-4.29%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0%> (-3.41%) 19% <0%> (-1%)
...dubbo/remoting/exchange/support/DefaultFuture.java 80.35% <0%> (-3.27%) 0% <0%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca28815...76af026. Read the comment docs.

CrazyHZM
CrazyHZM approved these changes Mar 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit b5cc276 into apache:master Mar 7, 2020
@CrazyHZM CrazyHZM mentioned this pull request Mar 7, 2020
Closed
2 tasks
chickenlj pushed a commit that referenced this pull request Mar 10, 2020
@xylsh @chickenlj
fix wrong telnet command package(#5690) (#5815)
ab5cf3d
This was referenced Apr 9, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CrazyHZM CrazyHZM CrazyHZM approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dubbo Telnet Unsupported command: ls

3 participants

@xylsh @codecov-io @CrazyHZM