Skip to content

[Dubbo-5813]prevent destroyAll method of DubboShutdownHook being invoked twice when using Spring#5814

Merged
tswstarplanet merged 2 commits intoapache:masterfrom
tswstarplanet:issue_5813
Mar 1, 2020
Merged

[Dubbo-5813]prevent destroyAll method of DubboShutdownHook being invoked twice when using Spring#5814
tswstarplanet merged 2 commits intoapache:masterfrom
tswstarplanet:issue_5813

Conversation

@tswstarplanet
Copy link
Copy Markdown
Contributor

fix #5813

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@tswstarplanet tswstarplanet merged commit 5194791 into apache:master Mar 1, 2020
chickenlj added a commit that referenced this pull request Mar 2, 2020
…ing invoked twice when using Spring (#5814)"

This reverts commit 5194791.
chickenlj added a commit that referenced this pull request Mar 2, 2020
…ing invoked twice when using Spring (#5814)" (#5818)

This reverts commit 5194791.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

destroyAll method of DubboShutdownHook will be invoke twice when using spring framework

1 participant