Skip to content

fix monitor filter: consumer side elapsed time is negative#5705

Merged
chickenlj merged 1 commit intoapache:masterfrom
chickenlj:monitorfilter-5482
Feb 2, 2020
Merged

fix monitor filter: consumer side elapsed time is negative#5705
chickenlj merged 1 commit intoapache:masterfrom
chickenlj:monitorfilter-5482

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj commented Feb 2, 2020

Alternative of #5482

@chickenlj chickenlj merged commit 67eecab into apache:master Feb 2, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 2, 2020

Codecov Report

Merging #5705 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5705      +/-   ##
============================================
- Coverage     61.51%   61.49%   -0.02%     
+ Complexity      492      491       -1     
============================================
  Files           926      926              
  Lines         37852    37852              
  Branches       5463     5463              
============================================
- Hits          23285    23278       -7     
- Misses        12047    12058      +11     
+ Partials       2520     2516       -4
Impacted Files Coverage Δ Complexity Δ
...rg/apache/dubbo/monitor/support/MonitorFilter.java 67.34% <66.66%> (ø) 0 <0> (ø) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0%> (-13.8%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 59.09% <0%> (-9.1%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 59.32% <0%> (-6.78%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0%> (-3.51%) 8% <0%> (-1%)
...exchange/support/header/HeaderExchangeHandler.java 61.94% <0%> (-2.66%) 0% <0%> (ø)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0%> (-1.91%) 16% <0%> (ø)
.../threadpool/manager/DefaultExecutorRepository.java 60% <0%> (-1.82%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) 8% <0%> (-1%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c355a1a...c0bbd1e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chickenlj @codecov-io