Skip to content

fixed bug that monitor consumer side elapsed is negative#5482

Closed
maxiaoguang64 wants to merge 1 commit intoapache:masterfrom
maxiaoguang64:master
Closed

fixed bug that monitor consumer side elapsed is negative#5482
maxiaoguang64 wants to merge 1 commit intoapache:masterfrom
maxiaoguang64:master

Conversation

@maxiaoguang64
Copy link
Copy Markdown
Contributor

@maxiaoguang64 maxiaoguang64 commented Dec 13, 2019 •
edited
Loading

example:
1、provider side system time is father consumer side system time
2、consumer side record start time 1576546020000
3、provider side overwrite consumer side start time 1576546040000
4、consumer side record end time 1576546030000
5、consumer side calculate elapsed -10000

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 13, 2019

Codecov Report

Merging #5482 into master will increase coverage by 0.03%.
The diff coverage is 27.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5482      +/-   ##
============================================
+ Coverage     61.06%   61.09%   +0.03%     
- Complexity      422      424       +2     
============================================
  Files           919      919              
  Lines         37502    37510       +8     
  Branches       5444     5447       +3     
============================================
+ Hits          22900    22918      +18     
+ Misses        12106    12094      -12     
- Partials       2496     2498       +2
Impacted Files Coverage Δ Complexity Δ
...rg/apache/dubbo/monitor/support/MonitorFilter.java 59.64% <27.27%> (-7.7%) 0 <0> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.34% <0%> (-1%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.5% <0%> (+0.62%) 29% <0%> (ø) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 68.18% <0%> (+2.27%) 0% <0%> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.14% <0%> (+2.99%) 0% <0%> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.68% <0%> (+3.5%) 9% <0%> (+1%) ⬆️
...pache/dubbo/remoting/transport/AbstractServer.java 57.5% <0%> (+3.75%) 0% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 60.22% <0%> (+4.54%) 21% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00febe9...3202d8e. Read the comment docs.

@beiwei30 beiwei30 added this to the 2.7.6 milestone Dec 13, 2019
@maxiaoguang64 maxiaoguang64 changed the title fix elapsed fixed bug that monitor consumer side elapsed is negative Dec 17, 2019
@chickenlj chickenlj self-assigned this Jan 3, 2020
@chickenlj chickenlj mentioned this pull request Feb 2, 2020
Merged
@chickenlj chickenlj closed this Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@chickenlj chickenlj

Labels

None yet

Projects

None yet

Milestone

2.7.6

Development

Successfully merging this pull request may close these issues.

4 participants

@maxiaoguang64 @codecov-io @chickenlj @beiwei30