Skip to content

optimize : Simplify ReflectUtils.java lambda expression#5574

Merged
AlbumenJ merged 1 commit intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-7
Mar 14, 2021
Merged

optimize : Simplify ReflectUtils.java lambda expression#5574
AlbumenJ merged 1 commit intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-7

Conversation

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
Copy link
Copy Markdown

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz commented Jan 2, 2020

What is the purpose of the change

optimize : Simplify ReflectUtils.java lambda expression

Brief changelog

1.dubbo-common/src/main/java/org/apache/dubbo/common/utils/ReflectUtils.java

Verifying this change

Passed unit tests

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 2, 2020 •
edited
Loading

Codecov Report

Merging #5574 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5574      +/-   ##
============================================
+ Coverage     61.26%   61.28%   +0.02%     
+ Complexity      425      422       -3     
============================================
  Files           922      922              
  Lines         37504    37498       -6     
  Branches       5432     5432              
============================================
+ Hits          22975    22981       +6     
+ Misses        12047    12040       -7     
+ Partials       2482     2477       -5
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/dubbo/common/utils/ReflectUtils.java 69.92% <100%> (-0.11%) 0 <0> (ø)
...in/java/org/apache/dubbo/common/utils/IOUtils.java 87.8% <100%> (-1.09%) 0 <0> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0%> (-7.96%) 19% <0%> (-2%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0%> (-5.67%) 0% <0%> (ø)
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.15% <0%> (-0.29%) 31% <0%> (-1%)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.44% <0%> (+0.34%) 0% <0%> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.14% <0%> (+1.49%) 0% <0%> (ø) ⬇️
...mmon/threadpool/support/AbortPolicyWithReport.java 89.18% <0%> (+5.4%) 0% <0%> (ø) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 75.86% <0%> (+6.89%) 0% <0%> (ø) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 86.48% <0%> (+7.2%) 0% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f1fad...16115c8. Read the comment docs.

AlbumenJ
AlbumenJ approved these changes Mar 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 279699f into apache:master Mar 14, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
@AlbumenJ
Pick from apache#5574 279699f
57beac0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz @codecov-io @AlbumenJ